fix: only send think=false to Ollama, not all custom providers#11520
Open
vominh1919 wants to merge 1 commit into
Open
fix: only send think=false to Ollama, not all custom providers#11520vominh1919 wants to merge 1 commit into
vominh1919 wants to merge 1 commit into
Conversation
The `think` parameter is Ollama-specific. Sending it to other custom providers (Mistral, Fireworks, Together.ai, vLLM) causes HTTP 422. Fix: gate behind Ollama detection. Fixes NousResearch#11237
Collaborator
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
reasoning_effort: noneis set, Hermes sendsextra_body["think"] = falseto every custom provider endpoint. Thethinkparameter is Ollama-specific and is rejected with HTTP 422 by non-Ollama providers (Mistral, Fireworks, Together.ai, vLLM).Fix
Gate
think=falsebehind Ollama detection using the same pattern as_is_ollama_glm_backend():self._ollama_num_ctxis set (auto-detected Ollama)ollama:11434(Ollama default port)Fixes #11237