Skip to content

gateway cant add DingTalk platform#11500

Closed
youngDoo wants to merge 1 commit into
NousResearch:mainfrom
youngDoo:main
Closed

gateway cant add DingTalk platform#11500
youngDoo wants to merge 1 commit into
NousResearch:mainfrom
youngDoo:main

Conversation

@youngDoo

@youngDoo youngDoo commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

gateway cant add DingTalk platform without key and secret, DingTalk uses client_id/client_secret from config.extra or env vars

What does this PR do?

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

gateway cant add DingTalk platform without key and secret
@teknium1

Copy link
Copy Markdown
Contributor

Merged via #11605 (#11605). Your commit was cherry-picked with authorship preserved (91e7aff). Thanks for catching the gap — get_connected_platforms() was silently omitting DingTalk which broke status displays for anyone who set it up.

One tiny cleanup on my side: stripped ~140 trailing whitespace characters from the new DingTalk branch line. Also added 4 regression tests covering extras, env vars, disabled, and missing-creds cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants