[codex] Respect proxy env for Codex clients#11414
Closed
Chesszyh wants to merge 1 commit into
Closed
Conversation
|
遇到了同样的问题，想问下 MR 为什么关了。。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpx.HTTPTransportwhen proxy environment variables are presentHTTPS_PROXY,HTTP_PROXY, andALL_PROXYRoot Cause
Hermes injects a custom
httpx.Client(transport=httpx.HTTPTransport(...))to add TCP keepalive socket options. When a custom transport is provided, httpx does not use its default environment proxy handling. Users behind local HTTP(S) proxies can therefore have Codex/OpenAI requests direct-connect even whenHTTPS_PROXYis configured, resulting in connection timeouts.Impact
This keeps the existing keepalive behavior for users without proxy env vars, while allowing proxied setups to work through the SDK/httpx default proxy-aware transport.
Validation
./venv/bin/python -m pytest tests/run_agent/test_create_openai_client_reuse.py -q./venv/bin/hermes chat -Q -t '' --max-turns 1 -q '只回复 OK 两个字母。'