Feat/delegate task profile#11169
Open
DJHellscream wants to merge 14 commits into
Open
Conversation
2 tasks
|
This closes a gap I've been working around for months — profile routing via terminal subprocess. The profile/toolset separation as orthogonal concerns is the right call. Good to see this moving. |
c217bd9 to
8b07886
Compare
Author
|
Resolved conflicts with base branch |
8b07886 to
95e4096
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This PR Do?
This PR makes
delegate_task(profile=...)reliably launch a profile-backed Hermes ACP worker under the selected profile's runtime/home instead of silently falling back to the parent runtime.It also tightens delegated-worker isolation:
This is the right approach because it makes named-profile delegation explicit and reliable without changing the behavior of normal non-profile delegation.
Related Issue
No dedicated issue for this change.
Type of Change
Changes Made
tools/delegate_tool.pydelegate_task(profile=...)build a profile-backed Hermes ACP child reliably.messaging, sosend_messagecannot leak into children.run_agent.pyacp_adapter/session.pyagent/copilot_acp_client.pytests/tools/test_delegate.pytests/acp/test_session.pytests/agent/test_copilot_acp_client.pytests/run_agent/test_run_agent.pywebsite/docs/guides/delegation-patterns.mdwebsite/docs/reference/tools-reference.mdwebsite/docs/user-guide/features/delegation.mdHow to Test
Run the targeted delegate/profile test slice:
In a Hermes session with any existing named profile, invoke
delegate_task(profile="<your-profile>", toolsets=["terminal","file"]).Confirm the delegated worker:
hermes --profile <your-profile> acp.delegate_task,clarify,memory,execute_code, orsend_message.Checklist
Code
fix(scope):,feat(scope):, etc.).pytest tests/ -qand all tests pass. See full-suite note below.Documentation & Housekeeping
docs/, docstrings) - or N/A.cli-config.yaml.exampleif I added/changed config keys - or N/A.CONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows - or N/A.Screenshots / Logs
Targeted delegate/profile slice:
Local disposable delegate-profile smoke also passed after rebasing onto current
main.Full-suite note:
origin/mainis baseline-red.main.maindid not confirm a branch-only regression.