Skip to content

feat(skills): add comfyui-mcp optional skill for generative image/video workflows#11143

Closed
kshitijk4poor wants to merge 1 commit into
mainfrom
feat/comfyui-skill
Closed

feat(skills): add comfyui-mcp optional skill for generative image/video workflows#11143
kshitijk4poor wants to merge 1 commit into
mainfrom
feat/comfyui-skill

Conversation

@kshitijk4poor

@kshitijk4poor kshitijk4poor commented Apr 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

New optional skill comfyui-mcp under optional-skills/creative/ — teaches Hermes to control a running ComfyUI instance via its REST API.

What's Included

  • SKILL.md — Setup (local/cloud/remote), Python helper functions for execute_code, common workflow patterns (txt2img, parameterized generation), queue management, MCP server integration option, and 10 documented pitfalls.
  • references/api.md — Compact ComfyUI REST API reference (endpoints, JSON formats, WebSocket events).
  • references/recipes.md — Ready-to-use workflow templates (SDXL txt2img, img2img, Flux txt2img).

Design

Follows the established skill-as-prompt pattern (like blender-mcp): the skill teaches the agent to interact with ComfyUI's REST API via execute_code using a reusable Python helper. No core code changes.

Key features of the helper:

  • COMFYUI_URL / COMFYUI_API_KEY env vars for flexible deployment (local, cloud, remote)
  • X-API-Key header support for Comfy Cloud
  • Dynamic model discovery (list_models()) instead of hardcoded filenames
  • Polling-based completion detection via /history/{prompt_id}

Testing

Verified end-to-end against a local ComfyUI 0.19.3 instance:

  • system_stats ✓, object_info ✓, queue_prompt ✓, wait_for_completion ✓, get_image ✓
  • Full txt2img workflow executed successfully with image output retrieved

Zero core code changes — skill-only PR.

@github-actions

github-actions Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

⚠️ Supply Chain Risk Detected

This PR contains patterns commonly associated with supply chain attacks. This does not mean the PR is malicious — but these patterns require careful human review before merging.

⚠️ WARNING: Outbound network calls (POST/PUT)

Outbound POST/PUT requests in new code could be data exfiltration. Verify the destination URLs are legitimate.

Matches (first 10):

73:+    with urllib.request.urlopen(req, timeout=timeout) as resp:
101:+    with urllib.request.urlopen(url) as resp:
132:+    with urllib.request.urlopen(req) as resp:

Automated scan triggered by supply-chain-audit. If this is a false positive, a maintainer can approve after manual review.

@github-actions

github-actions Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

⚠️ Supply Chain Risk Detected

This PR contains patterns commonly associated with supply chain attacks. This does not mean the PR is malicious — but these patterns require careful human review before merging.

⚠️ WARNING: Outbound network calls (POST/PUT)

Outbound POST/PUT requests in new code could be data exfiltration. Verify the destination URLs are legitimate.

Matches (first 10):

97:+    with urllib.request.urlopen(req, timeout=timeout) as resp:
125:+    with urllib.request.urlopen(url) as resp:
156:+    with urllib.request.urlopen(req) as resp:

Automated scan triggered by supply-chain-audit. If this is a false positive, a maintainer can approve after manual review.

@github-actions

github-actions Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

⚠️ Supply Chain Risk Detected

This PR contains patterns commonly associated with supply chain attacks. This does not mean the PR is malicious — but these patterns require careful human review before merging.

⚠️ WARNING: Outbound network calls (POST/PUT)

Outbound POST/PUT requests in new code could be data exfiltration. Verify the destination URLs are legitimate.

Matches (first 10):

96:+    with urllib.request.urlopen(req, timeout=timeout) as resp:
127:+    with urllib.request.urlopen(req) as resp:
160:+    with urllib.request.urlopen(req) as resp:

Automated scan triggered by supply-chain-audit. If this is a false positive, a maintainer can approve after manual review.

@kshitijk4poor kshitijk4poor changed the title feat(skills): add ComfyUI optional skill for generative image/video workflows feat(skills): add comfyui-mcp optional skill for generative image/video workflows Apr 18, 2026
@kshitijk4poor
feat(skills): add comfyui-mcp optional skill for generative image/vid…
0f05b18 
…eo workflows

New optional skill under optional-skills/creative/comfyui-mcp/ with:
- SKILL.md: Setup guide (local, cloud, remote), Python helper functions
  for execute_code, common workflow patterns (txt2img, parameterized gen),
  queue management, and MCP server integration option.
- references/api.md: ComfyUI REST API reference (endpoints, JSON formats).
- references/recipes.md: Ready-to-use workflow templates (SDXL txt2img,
  img2img, Flux).

Zero core code changes — skill-only PR. Uses the established
skill-as-prompt pattern (like blender-mcp): teaches the agent to
interact with ComfyUI's REST API via execute_code.
@github-actions

github-actions Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

⚠️ Supply Chain Risk Detected

This PR contains patterns commonly associated with supply chain attacks. This does not mean the PR is malicious — but these patterns require careful human review before merging.

⚠️ WARNING: Outbound network calls (POST/PUT)

Outbound POST/PUT requests in new code could be data exfiltration. Verify the destination URLs are legitimate.

Matches (first 10):

96:+    with urllib.request.urlopen(req, timeout=timeout) as resp:
127:+    with urllib.request.urlopen(req) as resp:
160:+    with urllib.request.urlopen(req) as resp:

Automated scan triggered by supply-chain-audit. If this is a false positive, a maintainer can approve after manual review.

@alt-glitch alt-glitch mentioned this pull request Apr 22, 2026
Open
7 tasks
@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) tool/mcp MCP client and OAuth labels Apr 25, 2026
@alt-glitch

alt-glitch commented Apr 25, 2026

Copy link
Copy Markdown
Collaborator

Related to #13271 — both add ComfyUI skills with different approaches (MCP/REST vs CLI-based).

This was referenced Apr 29, 2026
Closed
Closed
@teknium1 teknium1 mentioned this pull request Apr 29, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

P3 Low — cosmetic, nice to have tool/mcp MCP client and OAuth tool/skills Skills system (list, view, manage) type/feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kshitijk4poor @alt-glitch