fix(agent): avoid reusing mutated http client kwargs#11072
Closed
swnb wants to merge 1 commit into
Closed
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client_kwargsin_create_openai_client()http_clientRoot Cause
The keepalive change introduced a subtle gateway regression:
_create_openai_client()inserted a concretehttp_clientinto the passedclient_kwargsself._client_kwargsacross turnshttpx.Client/ transport pool instead of getting a fresh oneAPIConnectionError/APITimeoutErrorThis was especially visible in long-running gateway processes, while fresh-shell
hermes chat -q ...calls could still succeed.Fix
client_kwargson entry so the caller-owned dict is never mutated_client_kwargsis not mutatedhttp_clienthttpx's 5s default timeoutHow To Reproduce
Before this fix:
openai-codexConnection error./Request timed out.even for tiny promptslsofand note lingering stale sockets / pool reuse behaviorhermes chat -q ..., which can still succeedValidation
Tests:
pytest tests/run_agent/test_openai_client_lifecycle.py -qManual checks on macOS:
hermes chat -qsucceeds for both default and named profilePlatforms Tested
Closes #11070