fix #11030: create branch session before ending original session#11048
Open
vominh1919 wants to merge 1 commit into
Open
fix #11030: create branch session before ending original session#11048vominh1919 wants to merge 1 commit into
vominh1919 wants to merge 1 commit into
Conversation
…session /branch marked the original session as ended with end_reason='branched' BEFORE creating the new session. If create_session() failed, the original session was left in an inconsistent state (ended but still active). Now creates the new session first, and only ends the original on success. Fixes NousResearch#11030
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11030
/branchmarked the original session as ended withend_reason="branched"BEFORE creating the new session. Ifcreate_session()failed, the original session was left in an inconsistent state (ended but still active).Changes:
create_session()call BEFOREend_session()create_session()fails, the original session remains active