Skip to content

fix(docker): add openssh-client for SSH terminal backend#10838

Closed
Somme4096 wants to merge 1 commit into
NousResearch:mainfrom
Somme4096:fix/docker-openssh-client-v2
Closed

fix(docker): add openssh-client for SSH terminal backend#10838
Somme4096 wants to merge 1 commit into
NousResearch:mainfrom
Somme4096:fix/docker-openssh-client-v2

Conversation

@Somme4096

Copy link
Copy Markdown
Contributor

Supersedes #8195

What does this PR do?

Close #8186

Related Issue

#8186

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

In Dockerfile:

RUN apt-get update && \
    apt-get install -y --no-install-recommends \
        build-essential nodejs npm openssh-client python3 python3-pip ripgrep ffmpeg gcc python3-dev libffi-dev procps && \  # Added openssh-client here  
    rm -rf /var/lib/apt/lists/*

How to Test

  1. Build the image with the fix:
   docker build -t hermes-agent:test .
  1. Verify openssh-client is installed:
   docker run --rm hermes-agent:test which ssh
   # Expected: /usr/bin/ssh
   
   docker run --rm hermes-agent:test ssh -V
   # Expected: OpenSSH_x.x ...
  1. (Optional) Full SSH backend test:
   docker run --rm -e TERMINAL_SSH_HOST=host.docker.internal \
     -e TERMINAL_SSH_USER=$USER \
     -v ~/.ssh/id_ed25519:/root/.ssh/id_ed25519:ro \
     hermes-agent:test hermes chat -q "Run: whoami"

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

image

@teknium1

Copy link
Copy Markdown
Contributor

Thanks @Somme4096! Your commit was cherry-picked and merged via #14231 with your authorship preserved.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists area/docker Docker image, Compose, packaging backend/ssh SSH remote execution labels Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docker Docker image, Compose, packaging backend/ssh SSH remote execution P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Docker image missing openssh-client fo SSH terminal backend

3 participants