fix(dingtalk): resolve message extraction and callback type mismatch#10820
Closed
lshy0000 wants to merge 1 commit into
Closed
fix(dingtalk): resolve message extraction and callback type mismatch#10820lshy0000 wants to merge 1 commit into
lshy0000 wants to merge 1 commit into
Conversation
- Fix _IncomingHandler.process() to convert CallbackMessage to ChatbotMessage using ChatbotMessage.from_dict(), matching dingtalk-stream SDK behavior. - Replace manual _extract_text() logic with SDK's get_text_list() which correctly handles TextContent objects and richText messages. - Relax _DINGTALK_WEBHOOK_RE to match *.dingtalk.com (was api.dingtalk.com) to support oapi.dingtalk.com webhook URLs. - Add detailed debug logging for webhook caching and send() routing. - Remove blocking asyncio.to_thread() call since stream client now runs async natively in the main event loop. - Update test_dingtalk.py to use real ChatbotMessage.from_dict() instead of MagicMock for _extract_text() tests.
Contributor
|
Closing as superseded by #11471 (#11471) which salvaged @kevinskysunny's minimal fix (#11257) and added a follow-up for the broken Thanks for the fix — a lot of contributors hit this SDK break at the same time. Your investigation helped confirm the root cause. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs