fix(gateway): find_gateway_pids works on macOS#10684
Closed
yunkai wants to merge 1 commit into
Closed
Conversation
- Replace 'ps -A eww' with 'ps -ww' (POSIX-compatible, no truncation) The 'eww' flags were Linux/BSD-specific; combined with '-A' they silently produced empty output on macOS, causing the gateway status check to report 'not running' even when the process was alive. - Add explicit darwin branch: use 'ps aux' which puts full command in column 11+ (BSD-style output format differs from Linux). - Linux also falls back to 'ps aux' if 'ps -A ww' returns empty, preserving compatibility with distros that don't support 'ww'.
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hermes cron listreports 'Gateway is not running' even when the gateway process is actively running on macOS. This happens because the gateway status check usesps -A eww, which silently returns empty output on macOS (theewwflags are Linux/BSD-specific, and the-Aflag conflicts with-axwhich was previously used).Root cause
Commit
b80e318replacedps eww -axwithps -A eww, but-Aand-axare mutually exclusive. On macOS,pssilently ignores this invalid combination and returns empty output, causingfind_gateway_pids()to return[].Additionally,
ps -A+ewwis itself invalid syntax —ww(noe) is the POSIX-correct wide-output flag.Fix
ps -A ewwwithps -A ww(POSIX-compatible, no truncation)sys.platform == "darwin"branch usesps auxdirectly (BSD output format differs from Linux, column layout is different)ps auxifps -A wwreturns empty, for compatibility with distros that don't supportwwTesting
find_gateway_pids()correctly returns the running gateway PIDps -A wwpath is takenChecklist