fix(feishu): terminate process on unrecoverable websocket drops#10620
Open
watsonctl wants to merge 1 commit into
Open
fix(feishu): terminate process on unrecoverable websocket drops#10620watsonctl wants to merge 1 commit into
watsonctl wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10616
Description
When using the Feishu integration, if the underlying connection suffers a
keepalive ping timeout, the SDK's message loop exits, but the main Hermes agent process doesn't terminate or successfully reconnect. This leaves the Gateway in a zombie state where it appears "running" to system daemon managers (like systemd) but accepts no messages.This PR adds a Crash-Only architecture mechanism: if the Feishu websocket loop terminates unexpectedly while the gateway adapter is still running, it forces the process to crash (
os._exit(1)). This allows system level managers (Restart=always) to successfully identify the failure and restart the agent.