fix(feishu): patch approval cards after button resolution#10412
Open
Magic-Jia wants to merge 1 commit into
Open
fix(feishu): patch approval cards after button resolution#10412Magic-Jia wants to merge 1 commit into
Magic-Jia wants to merge 1 commit into
Conversation
13 tasks
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the Feishu command-approval card flow after a button click.
Previously, the card-resolution path could fail to match the pending approval when Feishu delivered
action.valueas a JSON string and/or returnedapproval_idas a string. The follow-up card update also usedmessage.update, which is less suitable for mutating the existing interactive card after a button click. This change makes the callback path tolerant to those payload shapes and patches the original card in place after resolution.Related Issue
No linked issue.
Type of Change
Changes Made
gateway/platforms/feishu.py:update_multion approval cards so they can be updated after an actionmessage.updatetomessage.patchaction.valuepayloads in card callbacksapproval_idarrives as a string instead of an inttests/gateway/test_feishu_approval_buttons.py:update_multi=Trueis present on approval cardsaction.valuewith stringapproval_idmessage.patchHow to Test
source venv/bin/activate && python -m pytest tests/gateway/test_feishu_approval_buttons.py -qChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs