Skip to content

fix(honcho): make client timeout configurable#10372

Closed
rahimsais wants to merge 1 commit into
NousResearch:mainfrom
rahimsais:fix/honcho-configurable-timeout
Closed

fix(honcho): make client timeout configurable#10372
rahimsais wants to merge 1 commit into
NousResearch:mainfrom
rahimsais:fix/honcho-configurable-timeout

Conversation

@rahimsais

@rahimsais rahimsais commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add timeout_seconds to HonchoClientConfig
  • allow timeout override from config and HONCHO_TIMEOUT_SECONDS
  • pass the configured timeout through to the Honcho SDK client
  • add regression tests for defaults, host override precedence, and SDK wiring

Problem

The Honcho client timeout is currently fixed in code. That is too rigid for self-hosted or local deployments, and it forces one hardcoded policy instead of letting operators tune the timeout explicitly.

Notes

This is related to #8527 but takes a config-driven approach instead of hardcoding a longer timeout for local base URLs only.

Test Plan

  • source venv/bin/activate && python -m pytest -q tests/honcho_plugin/test_client.py

@alt-glitch alt-glitch mentioned this pull request Apr 21, 2026
Closed
4 tasks
@erosika erosika mentioned this pull request Apr 24, 2026
Closed
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins labels Apr 26, 2026
@teknium1

teknium1 commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution, @rahimsais! This is exactly the right fix.

Unfortunately, an equivalent implementation landed on main the same day this PR was opened — commit cc6e8941 (part of the context injection overhaul merged 2026-04-15) added the same feature under a slightly different naming convention:

  • timeout: float | None = None field on HonchoClientConfig (plugins/memory/honcho/client.py:225)
  • HONCHO_TIMEOUT env var resolution in from_env() (line 302)
  • timeout / requestTimeout keys read from honcho.json in from_global_config() (lines 370–372)
  • honcho.timeout / honcho.request_timeout overlay from config.yaml in get_honcho_client() (lines 632–644)
  • SDK pass-through via kwargs["timeout"] (line 681)
  • Regression tests for defaults, env override, config override, and SDK wiring already in tests/honcho_plugin/test_client.py

Main's implementation is a superset of what this PR adds, so closing as implemented. Automated hermes-sweeper review.

@teknium1 teknium1 closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rahimsais @teknium1 @alt-glitch @donrhmexe