fix: repair dingtalk stream callbacks and replies#10369
Closed
junwu168 wants to merge 1 commit into
Closed
Conversation
- unwrap CallbackMessage payloads into ChatbotMessage objects - handle async DingTalk stream startup correctly - authorize DingTalk users via alternate staff IDs - preserve session webhooks for DM reply routing - add regression coverage for callback handling and webhook caching
Contributor
|
Closing as superseded by #11471 (#11471) which salvaged @kevinskysunny's minimal fix (#11257) and added a follow-up for the broken Thanks for the fix — a lot of contributors hit this SDK break at the same time. Your investigation helped confirm the root cause. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatbotMessageobjects before processingTesting
venv/bin/python -m pytest tests/test_dingtalk_adapter.py tests/gateway/test_unauthorized_dm_behavior.py -qvenv/bin/python -m py_compile gateway/platforms/dingtalk.py gateway/run.pyNotes
scripts/whatsapp-bridge/package-lock.jsonchange out of this PR