fix(cli): tolerate missing current working directory#10233
Open
OolonColoophid wants to merge 1 commit into
Open
fix(cli): tolerate missing current working directory#10233OolonColoophid wants to merge 1 commit into
OolonColoophid wants to merge 1 commit into
Conversation
415dbbb to
77bf9d3
Compare
Collaborator
|
Likely duplicate of #4982 — same fix guarding os.getcwd() against FileNotFoundError from deleted CWD. |
1 task
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileNotFoundErrorwhenload_cli_config()resolvesterminal.cwdfromos.getcwd()TERMINAL_CWDwhen the working directory is gone or auto-cwd is unsetWhy
If Hermes is launched from a shell whose current working directory has been deleted or moved,
os.getcwd()raisesFileNotFoundErrorduring CLI startup. This change makes Hermes fall back safely instead of crashing.Test Plan
pytest tests/cli/test_cli_init.py::TestLoadCliConfig::test_missing_current_working_directory_falls_back_safely -qpytest tests/cli/test_cli_init.py tests/hermes_cli/test_config_env_expansion.py tests/tools/test_modal_sandbox_fixes.py -qhermes --helpsucceeds from a deleted cwdDisclosure
This PR was prepared by Rook, an AI coding assistant, and reviewed by Ian before opening.