fix(security): add body size limit and defusedxml to prevent XML DoS before signature verification in WeCom callback#10192
Open
memosr wants to merge 1 commit into
Conversation
…before signature verification in WeCom callback
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
gateway/platforms/wecom_callback.pyparsed untrusted XML beforeverifying the WeCom signature, on an internet-facing endpoint
(
DEFAULT_HOST = "0.0.0.0").The vulnerability
Inside
_decrypt_request:Any attacker can POST malformed or malicious XML to
/wecom/callbackbefore any credential check runs. Python's
xml.etree.ElementTree(expat-based) is not safe against malicious input — billion laughs,
deeply nested trees, and malformed content all happen pre-auth.
Fix 1 — Body size limit (64 KB)
Added a payload size check before any parsing:
Fix 2 — defusedxml for safe XML parsing
Replaced
ET.fromstring()withdefusedxml.ElementTree.fromstring()which protects against billion laughs, quadratic blowup, and external
entity expansion:
Type of Change
Checklist
defusedxmlgracefully falls back to stdlib if not installed