Skip to content

feat(docker): add docker-cli to Docker image#10096

Closed
brianclemens wants to merge 1 commit into
NousResearch:mainfrom
brianclemens:main
Closed

feat(docker): add docker-cli to Docker image#10096
brianclemens wants to merge 1 commit into
NousResearch:mainfrom
brianclemens:main

Conversation

@brianclemens

Copy link
Copy Markdown
Contributor

What does this PR do?

This allows a Dockerized Hermes agent to use the docker shell backend (with Podman or Docker) by specifying /var/run/podman/podman.sock:/var/run/docker.sock or /var/run/docker.sock:/var/run/docker.sock as container mounts.

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • Just adds docker-cli to the installaed dependecnies in the container image.

How to Test

  1. Use a Dockerized Hermes agent to use the docker shell backend (with Podman or Docker) with /var/run/podman/podman.sock:/var/run/docker.sock or /var/run/docker.sock:/var/run/docker.sock specified as container mounts
  2. Observe that the docker shell backend functions
  3. Profit

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: Container on Rocky Linux 10

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

@RuckVibeCodes RuckVibeCodes left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gus-first-pass] Review completed. Verify that the Docker functionality works as intended after these changes.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks @brianclemens! Your commit was cherry-picked and merged via #14232 with your authorship preserved.

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have area/docker Docker image, Compose, packaging labels Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docker Docker image, Compose, packaging P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants