feat(docker): add docker-cli to Docker image#10096
Closed
brianclemens wants to merge 1 commit into
Closed
Conversation
RuckVibeCodes
left a comment
There was a problem hiding this comment.
[gus-first-pass] Review completed. Verify that the Docker functionality works as intended after these changes.
Contributor
|
Thanks @brianclemens! Your commit was cherry-picked and merged via #14232 with your authorship preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This allows a Dockerized Hermes agent to use the docker shell backend (with Podman or Docker) by specifying
/var/run/podman/podman.sock:/var/run/docker.sockor/var/run/docker.sock:/var/run/docker.sockas container mounts.Type of Change
Changes Made
docker-clito the installaed dependecnies in the container image.How to Test
/var/run/podman/podman.sock:/var/run/docker.sockor/var/run/docker.sock:/var/run/docker.sockspecified as container mountsChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/A