fix: make hindsight client timeout configurable via HINDSIGHT_TIMEOUT env var#10045
Open
nightq wants to merge 4 commits into
Open
fix: make hindsight client timeout configurable via HINDSIGHT_TIMEOUT env var#10045nightq wants to merge 4 commits into
nightq wants to merge 4 commits into
Conversation
added 4 commits
April 15, 2026 11:41
Fixes NousResearch#9999 Root cause: _sanitize_api_messages compared raw tool_call_id strings without stripping whitespace, causing valid tool results to be treated as orphaned when IDs had leading/trailing spaces. Fix: strip whitespace in _get_tool_call_id_static and when collecting result_call_ids from tool messages.
Fixes NousResearch#9980 Root cause: _send_raw_message hardcoded 'chat_id' as receive_id_type, causing [230001] invalid receive_id errors when sending to user open_ids (prefix 'ou_') or union_ids (prefix 'on_'). Fix: Add _detect_receive_id_type() that checks ID prefix (oc_→chat_id, ou_→open_id, on_→union_id) and use it in _send_raw_message.
Fixes NousResearch#9950 Root cause: Prompts discarded for having no reasoning were not added to completed_in_batch, causing --resume to retry them indefinitely. Fix: Append prompt_index to completed_in_batch before continuing past the discard branch.
… env var Fixes NousResearch#9869 Root cause: Hindsight cloud client had hardcoded 30s timeout, causing hindsight_reflect to fail for longer operations. Fix: Read timeout from HINDSIGHT_TIMEOUT env var with default of 300s.
|
This would be great! For now, I have told the agent to just retain and recall and avoid reflecting on anything 😆 Another issue I have noticed is that I tried to self-host Hindsight "the correct way" by having a separate Docker container serve the API and MCP, but the cloud and local options for the plugin didn't pair nicely with that. I managed to duct tape together a solution, but I think it's not a very elegant one. |
This was referenced Apr 22, 2026
Collaborator
|
Likely duplicate of #9985 — same fix: make Hindsight cloud client timeout configurable via HINDSIGHT_TIMEOUT env var (default 300s). |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the Hindsight cloud client timeout configurable to prevent
hindsight_reflectfailures on longer operations.Root Cause
The Hindsight cloud client was initialized with a hardcoded 30s timeout. The
hindsight_reflecttool performs LLM synthesis across the memory graph, which routinely takes longer than 30 seconds. While_run_sync()has a 120s wrapper, the inner HTTP client timeout fires first.Fix
Read timeout from
HINDSIGHT_TIMEOUTenv var with a default of 300s (matching other Hermes timeout defaults).Test Plan
Closes #9869