Skip to content

fix: resolve external skill dirs from config path#10017

Open
houziershi wants to merge 1 commit into
NousResearch:mainfrom
houziershi:fix/9949-external-dirs-config-base
Open

fix: resolve external skill dirs from config path#10017
houziershi wants to merge 1 commit into
NousResearch:mainfrom
houziershi:fix/9949-external-dirs-config-base

Conversation

@houziershi

Copy link
Copy Markdown

Summary

  • resolve relative skills.external_dirs entries relative to the active config.yaml location instead of the process working directory
  • preserve existing handling for absolute paths, environment expansion, deduplication, and missing directories
  • add a regression test proving cwd changes no longer break relative external skill directories

Test Plan

  • uv run --extra dev python -m pytest tests/agent/test_skill_utils.py -q

Closes #9949

@houziershi

Copy link
Copy Markdown
Author

Fix resolve external skill dirs from config path, ready for review.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/agent Core agent loop, run_agent.py, prompt builder tool/skills Skills system (list, view, manage) area/config Config system, migrations, profiles labels Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/agent Core agent loop, run_agent.py, prompt builder P2 Medium — degraded but workaround exists tool/skills Skills system (list, view, manage) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skills.external_dirs relative paths depend on process cwd instead of config location

2 participants