feat(dingtalk): add QR code scan authorization for setup wizard#10004
Closed
PeterGuy326 wants to merge 2 commits into
Closed
feat(dingtalk): add QR code scan authorization for setup wizard#10004PeterGuy326 wants to merge 2 commits into
PeterGuy326 wants to merge 2 commits into
Conversation
Adds device-flow QR scan auth to `hermes gateway setup` for DingTalk, eliminating manual credential entry. Falls back to manual input gracefully. Also adds DINGTALK_CLIENT_ID/SECRET env var auto-detection in config.py. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Closing — this PR ships the same three-step device flow as #8345 (meng93, Apr 12) and #9610 (audanye-sudo, Apr 14 — submitted one day before this one), which has now been merged via salvage PR #11574 (#11574). The code in this PR is word-for-word identical to #9610 with only cosmetic substitutions (box-drawing characters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes gateway setup), eliminating manual developer console workflowhermes_cli/dingtalk_auth.pymodule implements the 3-step registration flow (init/begin/poll)DINGTALK_CLIENT_ID/DINGTALK_CLIENT_SECRETenv var auto-detection ingateway/config.py(parity with other platforms)Test plan
.envuv pip, renders QR successfullyDINGTALK_CLIENT_IDdetected -> prompts "Reconfigure?"gateway/config.pyenv var detection:DINGTALK_CLIENT_ID+DINGTALK_CLIENT_SECRETin env -> platform auto-enabled🤖 Generated with Claude Code