Skip to content

fix(dingtalk): accept oapi.dingtalk.com webhook domain for stream mode reply routing#10002

Closed
PeterGuy326 wants to merge 1 commit into
NousResearch:mainfrom
PeterGuy326:fix/dingtalk-webhook-domain
Closed

fix(dingtalk): accept oapi.dingtalk.com webhook domain for stream mode reply routing#10002
PeterGuy326 wants to merge 1 commit into
NousResearch:mainfrom
PeterGuy326:fix/dingtalk-webhook-domain

Conversation

@PeterGuy326

Copy link
Copy Markdown

Summary

  • DingTalk Stream SDK returns sessionWebhook URLs using oapi.dingtalk.com domain, but the SSRF validation regex only accepted api.dingtalk.com, causing all reply routing via session webhooks to silently fail in stream mode
  • Updated regex to accept both api.dingtalk.com and oapi.dingtalk.com domains

Test plan

  • Verify regex matches both https://api.dingtalk.com/... and https://oapi.dingtalk.com/...
  • Verify regex rejects non-DingTalk domains (SSRF protection intact)
  • Test DingTalk stream mode end-to-end: bot receives messages and replies successfully via oapi.dingtalk.com session webhooks

🤖 Generated with Claude Code

…e reply routing

DingTalk Stream SDK returns sessionWebhook URLs using oapi.dingtalk.com domain,
but the SSRF validation regex only accepted api.dingtalk.com, causing all reply
routing via session webhooks to silently fail in stream mode.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@meng93

meng93 commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

fix my problem

@teknium1

Copy link
Copy Markdown
Contributor

Closing — the oapi.dingtalk.com webhook domain is now accepted on main as of #11471 (#11471). Thanks for catching and reporting this.

@teknium1 teknium1 closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants