-
Notifications
You must be signed in to change notification settings - Fork 33.7k
hermes setup quick wizard silently advances when MiniMax OAuth fails #19336
Copy link
Copy link
Closed as not planned
Closed as not planned
Copy link
Labels
P2Medium — degraded but workaround existsMedium — degraded but workaround existsarea/authAuthentication, OAuth, credential poolsAuthentication, OAuth, credential poolscomp/cliCLI entry point, hermes_cli/, setup wizardCLI entry point, hermes_cli/, setup wizardprovider/minimaxMiniMax (Anthropic transport)MiniMax (Anthropic transport)sweeper:implemented-on-mainSweeper: behavior already present on current mainSweeper: behavior already present on current maintype/bugSomething isn't workingSomething isn't working
Metadata
Metadata
Assignees
Labels
P2Medium — degraded but workaround existsMedium — degraded but workaround existsarea/authAuthentication, OAuth, credential poolsAuthentication, OAuth, credential poolscomp/cliCLI entry point, hermes_cli/, setup wizardCLI entry point, hermes_cli/, setup wizardprovider/minimaxMiniMax (Anthropic transport)MiniMax (Anthropic transport)sweeper:implemented-on-mainSweeper: behavior already present on current mainSweeper: behavior already present on current maintype/bugSomething isn't workingSomething isn't working
Type
Fields
Give feedbackNo fields configured for issues without a type.
Summary
In the
hermes setupquick-setup wizard, choosing "MiniMax via OAuth browser login" as the model provider produces no visible output at all -- no message, no browser launch, no error -- and the wizard immediately advances to the next prompt (e.g., "Connect a messaging platform?"). A user has no way to tell that auth failed and will assume MiniMax is configured.Notably, the same MiniMax OAuth flow invoked from
hermes modeldoes surface auth errors correctly. So the bug is in the quick-setup wizard's error handling, not the OAuth code itself.Repro
hermes setup.MiniMax via OAuth browser login.In our case the underlying root cause was an OAuth 307 redirect that httpx wasn't following (filed separately as a PR with the redirect fix). But even with that fixed, the silent-failure UX is its own bug -- any future OAuth-side error (network, server, expired client, etc.) will hit the same swallowed-exception path.
Expected behavior
The wizard should surface auth errors the same way
hermes modeldoes -- print the error, and either let the user retry or clearly mark the provider as not configured before moving on. At minimum, wizard exceptions in this code path shouldn't be silently caught and discarded.Environment
Notes
hermes modeltakes a different path and works correctly.