Skip to content

Secret redaction breaks functional credential use in terminal commands #16843

@frogwraps

Description

@frogwraps

Problem

The security.redact_secrets feature replaces credential strings with asterisks in both tool output AND command execution contexts. This creates a functional breakage: when the agent needs to use a password in a terminal command (e.g., htpasswd -nb user Passw0rd!), the redaction either:

  1. Masks the password with **** in the command itself, breaking actual command execution
  2. Or the raw password appears in chat output, exposing credentials

Expected Behavior

Secret redaction should protect credentials in:

  • Display output / chat messages (masked)
  • Session logs / transcripts (masked)

But should NOT interfere with:

  • Actual command execution (the real value must be used)
  • File writes to credential files / .env files

Suggested Fix

  1. Add a security.display_redaction_only flag — redact secrets in output/logs but pass real values to subprocesses
  2. At minimum, add clear documentation about how to handle credentials in terminal commands without exposure

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High — major feature broken, no workaroundarea/configConfig system, migrations, profilestool/terminalTerminal execution and process managementtype/bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions