Skip to content

[Bug]: terminal.container_persistent (= false) setting is not respected #1679

@ksze

Description

@ksze

Bug Description

After setting terminal.container_persistent to false in config.yaml, Hermes still leaves docker containers behind.
Image

Steps to Reproduce

  1. Open the Hermes config.yaml and set terminal.backend to "docker" and terminal.container_persistent to false:
    terminal:
      backend: docker
      container_persistent: false
  2. Chat with Hermes and ask it to do something that requires using the terminal (just listing files in a folder should do). I've been chatting with Hermes over Discord, but I doubt it makes a difference whether you chat over the terminal or over Telegram.

Expected Behavior

Container is removed after Hermes is done using it.

Actual Behavior

Container remains.

Affected Component

Tools (terminal, file ops, web, code execution, etc.)

Messaging Platform (if gateway-related)

N/A (CLI only), Discord

Operating System

Ubuntu 24.04 in WSL2, Windows 11 Pro host

Python Version

3.11.11

Hermes Version

0.3.0

Relevant Logs / Traceback

Root Cause Analysis (optional)

No response

Proposed Fix (optional)

No response

Are you willing to submit a PR for this?

  • I'd like to fix this myself and submit a PR

Metadata

Metadata

Assignees

No one assigned

    Labels

    type/bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions