Skip to content

Conversation

@lunaynx
Copy link
Contributor

@lunaynx lunaynx commented Mar 11, 2025

Updated the Pronoun enum to remove the unused possessive, and changed it so that "it" pronouns display as "it/its" instead of "it/it".

While technically the object form is "it", we are only using this to render pronouns from PronounDB, which itself renders them as "it/its", matching common usage. Therefore I chose to not overcomplicate the code by adding a second type of override for this, instead I just added a comment about this in case somehow the enum gets used for other things where the distinction is important in the future.

Copy link
Member

@NopoTheGamer NopoTheGamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure ok

@NopoTheGamer NopoTheGamer merged commit 768d93d into NotEnoughUpdates:master Apr 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants