Skip to content

Fix Issues with Effects Tablist Widget #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jani270 merged 5 commits into from
Jul 7, 2024
Merged

Fix Issues with Effects Tablist Widget #1201

jani270 merged 5 commits into from
Jul 7, 2024

Conversation

@NopoTheGamer
Copy link
Member

@NopoTheGamer NopoTheGamer commented Jun 5, 2024 •
edited
Loading

  • Fixes booster cookie warning to use widget
  • Fixes god pot on todo not updating with new widget
  • adds the footer to the tablist lines

@NopoTheGamer
Copy link
Member Author

NopoTheGamer commented Jun 5, 2024

Fixes #1063

@NopoTheGamer NopoTheGamer linked an issue Jun 6, 2024 that may be closed by this pull request
CookieWarning: Doesnt work with new Effects Widget in Tab #1063
Closed
@jani270 jani270 changed the title Fix cookie warning Fix Booster Cookie Warning not working with the Effects Tablist Widget Jun 7, 2024
@jani270
Copy link
Collaborator

jani270 commented Jun 7, 2024

Worked for me cant say much about the code tho

NopoTheGamer and others added 2 commits June 7, 2024 22:59
@NopoTheGamer @jani270
the println is system.out of here
16f8f09 
Co-authored-by: jani270 <69345714+jani270@users.noreply.github.com>
@NopoTheGamer
update god potion to also use new tab widget for todo overlay
1143dcd
@NopoTheGamer NopoTheGamer changed the title Fix Booster Cookie Warning not working with the Effects Tablist Widget Fix Issues with Effects Tablist Widget Jun 10, 2024
lineargraph
lineargraph requested changes Jul 6, 2024
View reviewed changes
@jani270 jani270 requested a review from lineargraph July 7, 2024 10:52
@jani270 jani270 merged commit 8f43c38 into master Jul 7, 2024
@jani270 jani270 deleted the cookieing branch July 7, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jani270 jani270 jani270 left review comments

@lineargraph lineargraph lineargraph approved these changes

@Lulonaut Lulonaut Lulonaut approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CookieWarning: Doesnt work with new Effects Widget in Tab

5 participants

@NopoTheGamer @jani270 @lineargraph @Lulonaut