-
Notifications
You must be signed in to change notification settings - Fork 161
Fix slot binding in chest or non-player GUIs #1189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
remove misleading comments
src/main/java/io/github/moulberry/notenoughupdates/miscfeatures/SlotLocking.java
Outdated
Show resolved
Hide resolved
|
Does this fix #519 ? |
# Conflicts: # src/main/java/io/github/moulberry/notenoughupdates/miscfeatures/SlotLocking.java
I didn't realise there was an issue open but yes it does. |
NopoTheGamer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you shift click from hotbar it will just go into the chest and then the link will be broken once you exit the chest. Slot binding just full doesn't work either side in the furnace, did notice it works perfectly in the dropper
That's odd, I tested in a furnace but I'll double check, I think the other issue was pre existing but I'll look into it as well |
I can confirm that shift clicking the hotbar was an issue prior to my changes, I have looked into it more and just don't know how to fix it as stated below. As far as I can tell the only issue with furnace (and it also applies to other guis like chests) is spam clicking which I think causes the shift click to be processed by minecraft once the item is moved to the hotbar (aka the same issue as before). The issue isn't my doing and it wasn't my original intention to fix because it is a much more niche issue (seeing as how the intended behavior is achieved with inventory -> hotbar, not hotbar -> inventory which is what causes the bug), however I did try and fail to fix it. |
Fix a desync between the event slot number and the gui slot number.