Skip to content

Add Recipe Search Overlay #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lineargraph merged 21 commits into from
Aug 4, 2024
Merged

Add Recipe Search Overlay #1045

lineargraph merged 21 commits into from
Aug 4, 2024

Conversation

@Conutik
Copy link
Contributor

@Conutik Conutik commented Mar 12, 2024 •
edited
Loading

Added recipe search overlay which uses the same way ah and bz search overlays are made.

Known bugs that I couldn't fix:

  • Ghost shadow appearing in different pages other than crafting menu without the pickaxe. (FIXED)
  • Shift clicking an item crashes the game (FIXED)

(Fifth time's the charm)

DuckySoLucky
DuckySoLucky approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@DuckySoLucky DuckySoLucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, didn't test

@Conutik Conutik requested a review from DuckySoLucky March 12, 2024 14:42
@hannibal002 hannibal002 modified the milestone: 2.1.1 Mar 12, 2024
@jani270 jani270 requested review from Lulonaut and lineargraph March 19, 2024 15:43
@jani270 jani270 added the feature This PR adds a feature label Mar 19, 2024
@NopoTheGamer
Copy link
Member

NopoTheGamer commented Jul 16, 2024

I have fixed up this pr
it now depends on #1248

@NopoTheGamer NopoTheGamer changed the title Added Recipe Search Overlay Add Recipe Search Overlay Jul 16, 2024
@NopoTheGamer NopoTheGamer requested a review from lineargraph July 16, 2024 01:03
@NopoTheGamer
Merge branch 'refs/heads/master' into fork/Conutik/master
1414191 
# Conflicts:
#	src/main/java/io/github/moulberry/notenoughupdates/mixins/MixinGuiContainer.java
#	src/main/kotlin/io/github/moulberry/notenoughupdates/commands/misc/SearchCommand.kt
@NopoTheGamer
fix pet replacements !
1bcb641
@lineargraph lineargraph merged commit 17bce62 into NotEnoughUpdates:master Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lineargraph lineargraph lineargraph approved these changes

@Lulonaut Lulonaut Lulonaut approved these changes

+1 more reviewer

@DuckySoLucky DuckySoLucky DuckySoLucky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature This PR adds a feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Conutik @NopoTheGamer @lineargraph @Lulonaut @DuckySoLucky @hannibal002 @jani270