add price source and sorting buttons to /pv sack page #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jani270
reviewed
Mar 10, 2024
Collaborator
jani270
left a comment
There was a problem hiding this comment.
Just some style things, also might wanna move the buttons more into the middle and down?
src/main/kotlin/io/github/moulberry/notenoughupdates/miscfeatures/profileviewer/SacksPage.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/github/moulberry/notenoughupdates/miscfeatures/profileviewer/SacksPage.kt
Outdated
Show resolved
Hide resolved
lineargraph
approved these changes
Mar 11, 2024
Member
lineargraph
left a comment
There was a problem hiding this comment.
Works nicely. Feel free to merge.
| object KotlinRenderUtils { | ||
|
|
||
| @JvmStatic | ||
| fun renderItemStackButton(button: Rectangle, item: ItemStack, texture: ResourceLocation) { |
Member
There was a problem hiding this comment.
I feel like taking in a Rectangle here is a bit misleading, since the actual dimensions of the rectangle are entirely ignored (not used for the texture or centering the itemstack.
Comment on lines
+422
to
+428
| if (priceSourceButtonRect.contains(mouseX, mouseY)) { | ||
| currentPriceSource = PriceSource.values()[(currentPriceSource.ordinal + 1) % PriceSource.values().size] | ||
| Utils.playPressSound() | ||
| getData() | ||
| } | ||
|
|
||
| if (sortButtonRect.contains(mouseX, mouseY)) { |
Member
There was a problem hiding this comment.
At this point we might as well add a utility like
inline fun <reified E : Enum<E>> E.nextEnum(): E {
val values = enumValues<E>()
return values[(ordinal + 1) % values.size]
}
Not really needed here tho.
Comment on lines
+72
to
+73
| // Lazy initialisation to allow for guiLeft and guiTop to be initialized first | ||
| private val priceSourceButtonRect by lazy { Rectangle(guiLeft + 54, guiTop + 155, 20, 20) } |
Member
There was a problem hiding this comment.
Technically this breaks if the window gets resized. Then again, we don't have any mechanism for invalidating these rects, so this will be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #934
closes #935