Fixed golden dragon pet skin #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lineargraph
approved these changes
Feb 29, 2024
Member
lineargraph
left a comment
There was a problem hiding this comment.
Hey i recognize that chat message
Lulonaut
approved these changes
Mar 5, 2024
Contributor
Lulonaut
left a comment
There was a problem hiding this comment.
after some testing with one of my several lvl 200 golden dragon pets, it seems to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed autopet rule in chat not getting detected when using the new golden dragon pet skin that adds the cosmetic overflow levels to the pet name.
Also using labelled regex groups for better maintainability.
Also extracted pet color and pet name into two groups for better readability.
Also extracted get pet rarity by color code into own function for smaller function size.