Add tab list tutorial #1014
Merged
Add tab list tutorial #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todo: Add patterns for all the other widgets. An Example implementation can be seen in MiningOverlay.java. If the requested Widget is not present, a TablistTutorial task will be added to the queue, which informs the user that they need to enable it. Otherwise (hopefully) only the requested information will be returned, removing the need to constantly check which part of the tab list is currently being parsed.
# Conflicts: # src/main/java/io/github/moulberry/notenoughupdates/util/ItemUtils.java
Contributor
|
other TODO I forgot: obviously change all other tab list parsers over to this new API |
Also attempted to (but failed) to fix the skills being detected
Collaborator
|
https://i.imgur.com/ovS5Kdp.png Shows outside of skyblock lol |
…blist Most api calls probably don't care about the current region, so the getWidgetLines function shouldn't care either. For an explicit region, getWidgetLinesInRegion can be used.
Fix warning showing right after enabling the widget This fix assumes the skyblock player is capable of not disabling the widget after enabling it. Fix /neustats Has Advanced Tab Instead added /neustats tablist, which copies the entire Tablist to the clipboard. Deleted all SBInfo#hasNewTab usages in the process. Also converted the MiningOverlay to show the warning inside the overlay, and only if the relevant lines are actually enabled.
…nto fork/alphatutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Hide Empty And Locked Forge Slotsenabled, tablist shows this'§9§lForges: §r§f(0/5)'