fix: quantize colors in environments without true color support#36
fix: quantize colors in environments without true color support#36Norbert515 merged 2 commits intoNorbert515:mainfrom
Conversation
Remove extra blank line after HSVColor class to satisfy dart format.
PR looks good, I'm just trying to reproduce the broken state. I'm running the MacOS default terminal without these changes and the |
|
I'm going to look into this because none of my settings seemed to affect it. Maybe it's something in my .zshrc file. I'll report back once I narrow it down. |
|
Okay, it's not anything in my .zshrc file. It might be that I customized some colors at some point (I vaguely recall doing that) and that almost certainly changes how Apple's terminal does the color quantization. Still, it may be beneficial to do the color quantization here in the library for the most consistent results. |
|
Yes, I agree! I just wanted to double check that I'd be able to reproduce the issue. Nonetheless, PR looks good and you got tests & verified to works for you so that should be enough! |
|
Thank you! Was fun to learn about this! |
This is a very neat library. Thank you for making it!
I noticed that colors were wildly off in the macOS terminal (mine was set to xterm-256), even though it looked fine in the VSCode terminal. So, I used an AI (codex) to diagnose and make this change + some human cleanup.
This change makes an attempt to detect if we're in a terminal that does not support true color. If the terminal does not support true color, it will attempt to quantize the color to the nearest 256 colors. I suppose this is not necessarily useful for environments with less than 256 colors...but I'm unaware of how to detect support for even more restricted environments.
From my testing, these changes seem to work well in both light and dark mode in the macOS terminal.
The color computations and detection are cached to avoid slowing down the rendering hot-path any more than necessary.
Dark
Before:
After:
Light
Before:
After:
Gruvbox Dark
Before:
After:
Catpuccin Mocha
Before:
After:
Nord
Before:
After:
Dracula
Before:
After:
