Forbid some empty separated lists in v2#667
Merged
Xanewok merged 12 commits intoNomicFoundation:mainfrom Nov 22, 2023
Merged
Conversation
See https://docs.soliditylang.org/en/latest/grammar.html#a4.SolidityParser.tupleExpression Unfortunately, we use `Separated(Optional(...))` in both definitions, which wrongly accepts an empty list in this specific case.
|
OmarTawfik
reviewed
Nov 20, 2023
OmarTawfik
reviewed
Nov 20, 2023
OmarTawfik
reviewed
Nov 20, 2023
...testing/snapshots/cst_output/TupleDeconstructionStatement/empty/generated/0.4.11-success.yml
Outdated
Show resolved
Hide resolved
OmarTawfik
reviewed
Nov 20, 2023
crates/solidity/testing/snapshots/cst_output/UsingDirective/destructure_empty/input.sol
Show resolved
Hide resolved
OmarTawfik
requested changes
Nov 20, 2023
Contributor
OmarTawfik
left a comment
There was a problem hiding this comment.
Left a couple of questions
OmarTawfik
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #652
These are a bug-fixes along with regression tests added for each case, we use a definition from v0/v1 for these.