Clean-up parser codegen and allow constructing DSL v1 model directly#656
Merged
Xanewok merged 5 commits intoNomicFoundation:mainfrom Nov 15, 2023
Merged
Conversation
It wasn't ever used as far as I understand and makes the migration to DSL v2 a bit easier.
Easy to re-introduce once they're needed, otherwise it's just noise for now.
It's more idiomatic to use implicit Deref and accept arguments by-ref if we do not need to know about the specific container/wrapper they're in.
|
OmarTawfik
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #638
Split out of #650