Skip to content

adding design docs for language definition v2#617

Merged
OmarTawfik merged 2 commits intoNomicFoundation:mainfrom
OmarTawfik-forks:dsl-v2-docs
Nov 3, 2023
Merged

adding design docs for language definition v2#617
OmarTawfik merged 2 commits intoNomicFoundation:mainfrom
OmarTawfik-forks:dsl-v2-docs

Conversation

@OmarTawfik
Copy link
Copy Markdown
Contributor

@OmarTawfik OmarTawfik commented Oct 23, 2023

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 23, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: d962647

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik marked this pull request as ready for review October 23, 2023 12:48
@OmarTawfik OmarTawfik requested a review from a team as a code owner October 23, 2023 12:48
@OmarTawfik OmarTawfik changed the title add dsl v2 docs adding design docs for language definition v2 Oct 23, 2023
AntonyBlakey
AntonyBlakey suggested changes Oct 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@AntonyBlakey AntonyBlakey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

@OmarTawfik OmarTawfik enabled auto-merge November 2, 2023 05:14
This was referenced Nov 3, 2023
Closed
Closed
Closed
@OmarTawfik OmarTawfik added this pull request to the merge queue Nov 3, 2023
Merged via the queue into NomicFoundation:main with commit c5a307d Nov 3, 2023
@OmarTawfik OmarTawfik deleted the dsl-v2-docs branch November 3, 2023 12:33
@OmarTawfik OmarTawfik mentioned this pull request Nov 5, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AntonyBlakey AntonyBlakey AntonyBlakey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OmarTawfik @AntonyBlakey