Discern invalid and missing syntax with different terminal kinds#1013
Merged
Xanewok merged 3 commits intoNomicFoundation:mainfrom Jun 20, 2024
Merged
Discern invalid and missing syntax with different terminal kinds#1013Xanewok merged 3 commits intoNomicFoundation:mainfrom
Xanewok merged 3 commits intoNomicFoundation:mainfrom
Conversation
|
AntonyBlakey
approved these changes
Jun 19, 2024
Contributor
Author
|
During the sync call we came to a conclusion that we'll go ahead with this approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #969
Closes #835
Closes #507
Closes #700
This implements the idea from #835:
TerminalKind::MISSINGTerminalKind::SKIPPEDtoTerminalKind::UNRECOGNIZEDTerminalKind::MISSINGinstead ofTerminalKind::UNRECOGNIZEDwhen the tree is emptyWhen writing this, I came to a conclusion that actually using two distinc terminal kinds might do more harm than good here, see #835 (comment).