As discussed f2f. - [x] Remove `LeadingTrivia` and `TrailingTrivia` non-terminals. - [x] Include the underlying trivia as siblings to the other rules/tokens in the parent directly. - [x] Use `FieldName::LeadingTrivia` and `FieldName::TrailingTrivia` for the promoted siblings. - [x] Remove `fn is_trivia()` for `RuleKind`, since it is impossible for any variant. - [x] Implement `fn is_trivia()` correctly for `TokenKind` based on `Item::Trivia`, instead of returning `false`. (#862)
As discussed f2f.
LeadingTriviaandTrailingTrivianon-terminals.FieldName::LeadingTriviaandFieldName::TrailingTriviafor the promoted siblings.fn is_trivia()forRuleKind, since it is impossible for any variant.fn is_trivia()correctly forTokenKindbased onItem::Trivia, instead of returningfalse. (Fix parsing ambiguous call options #862)