Skip to content

Commit 46cf20f

Browse files
committed
Remove remaining mentions of #638 in the code
1 parent 83cfe98 commit 46cf20f

3 files changed

Lines changed: 3 additions & 8 deletions

File tree

crates/codegen/language/definition/src/model/terminals/trivia.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ pub enum TriviaParser {
1010
Choice { parsers: Vec<TriviaParser> },
1111

1212
Optional { parser: Box<TriviaParser> },
13-
// TODO(#638): Remove this, once we adapt the DSL v1 codegen model to the new v2 definition.
1413
OneOrMore { parser: Box<TriviaParser> },
1514
ZeroOrMore { parser: Box<TriviaParser> },
1615

crates/codegen/runtime/generator/src/parser/grammar.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
1-
//! Definitions of the [`GrammarElement`]s and the grammar itself ([`Grammar`]).
2-
3-
// TODO(#638): This is a leftover module from the original DSLv1 implementation.
4-
// We should remove it and replace the grammar construction in the super `parser`
5-
// module with the one from the new DSLv2 in the `constructor` module.
1+
//! Definitions of the [`GrammarElement`]s and the grammar itself ([`Grammar`]) used by the parser generator.
62
73
use std::collections::HashMap;
84
use std::rc::Rc;

crates/solidity/inputs/language/src/definition.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ codegen_language_macros::compile!(Language(
55
documentation_dir = "crates/solidity/inputs/language/docs",
66
binding_rules_file = "crates/solidity/inputs/language/bindings/rules.msgb",
77
root_item = SourceUnit,
8-
// TODO(#638): For now this is on par with the DSL v1 definition to minimize the fallout.
9-
// We should replace this with the new definition from #629.
8+
// TODO(#1020): Define the end-of-file trivia explicitly rather than
9+
// implicitly reusing the leading trivia in the generater parser code.
1010
leading_trivia = OneOrMore(Choice([
1111
Trivia(Whitespace),
1212
Trivia(EndOfLine),

0 commit comments

Comments
 (0)