File tree Expand file tree Collapse file tree
language/definition/src/model/terminals
runtime/generator/src/parser
solidity/inputs/language/src Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -10,7 +10,6 @@ pub enum TriviaParser {
1010 Choice { parsers : Vec < TriviaParser > } ,
1111
1212 Optional { parser : Box < TriviaParser > } ,
13- // TODO(#638): Remove this, once we adapt the DSL v1 codegen model to the new v2 definition.
1413 OneOrMore { parser : Box < TriviaParser > } ,
1514 ZeroOrMore { parser : Box < TriviaParser > } ,
1615
Original file line number Diff line number Diff line change 1- //! Definitions of the [`GrammarElement`]s and the grammar itself ([`Grammar`]).
2-
3- // TODO(#638): This is a leftover module from the original DSLv1 implementation.
4- // We should remove it and replace the grammar construction in the super `parser`
5- // module with the one from the new DSLv2 in the `constructor` module.
1+ //! Definitions of the [`GrammarElement`]s and the grammar itself ([`Grammar`]) used by the parser generator.
62
73use std:: collections:: HashMap ;
84use std:: rc:: Rc ;
Original file line number Diff line number Diff line change @@ -5,8 +5,8 @@ codegen_language_macros::compile!(Language(
55 documentation_dir = "crates/solidity/inputs/language/docs" ,
66 binding_rules_file = "crates/solidity/inputs/language/bindings/rules.msgb" ,
77 root_item = SourceUnit ,
8- // TODO(#638 ): For now this is on par with the DSL v1 definition to minimize the fallout.
9- // We should replace this with the new definition from #629 .
8+ // TODO(#1020 ): Define the end-of-file trivia explicitly rather than
9+ // implicitly reusing the leading trivia in the generater parser code .
1010 leading_trivia = OneOrMore ( Choice ( [
1111 Trivia ( Whitespace ) ,
1212 Trivia ( EndOfLine ) ,
You can’t perform that action at this time.
0 commit comments