Skip to content

fix: don't override grep options in test task#2476

Merged
fvictorio merged 2 commits intoNomicFoundation:masterfrom
smartcontracts:sc/fix-hh-test-grep
Mar 18, 2022
Merged

fix: don't override grep options in test task#2476
fvictorio merged 2 commits intoNomicFoundation:masterfrom
smartcontracts:sc/fix-hh-test-grep

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

Fixes a bug in the test task that would override the grep options in the config file.

Fixes #2459

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 10, 2022

🦋 Changeset detected

Latest commit: 3a6c581

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 10, 2022

CLA assistant check
All committers have signed the CLA.

@tynes
Copy link
Copy Markdown

tynes commented Mar 17, 2022

Bump on this :)

@fvictorio
Copy link
Copy Markdown
Contributor

Thank you, Kelvin! I always forget that { a: 1, ...{a: undefined} } results in { a: undefined } 😞

@fvictorio fvictorio merged commit bd1d6b9 into NomicFoundation:master Mar 18, 2022
@smartcontracts smartcontracts deleted the sc/fix-hh-test-grep branch March 24, 2022 23:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not override config.mocha.grep when running test without --grep option

4 participants