PYTHON-4636 Always remove reader/writer callbacks#1
Merged
NoahStapp merged 1 commit intoNoahStapp:PYTHON-4636from Oct 3, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-4636 Always remove reader/writer callbacks
Fixes test_find_raw_retryable_reads. This test was failing when a previous task failed to remove its reader/writer callbacks, leading to the same file descriptor being added twice. Because FDs are recycled the stale callback consumes the event when trying to read from the newly opened FD. The fix is to always remove the callbacks even when the task is cancelled (ie when
await futraises).