Skip to content

emacs: Remove references from emacs.pdmp#99239

Merged
adisbladis merged 1 commit intoNixOS:masterfrom
edolstra:emacs-closure
Oct 1, 2020
Merged

emacs: Remove references from emacs.pdmp#99239
adisbladis merged 1 commit intoNixOS:masterfrom
edolstra:emacs-closure

Conversation

@edolstra
Copy link
Copy Markdown
Member

@edolstra edolstra commented Oct 1, 2020

Motivation for this change

This reduces the Emacs closure size from 1324 MiB to 424 MiB.

Fixes #98755.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This reduces the Emacs closure size from 1324 MiB to 424 MiB.

Fixes NixOS#98755.
@edolstra edolstra requested a review from adisbladis as a code owner October 1, 2020 07:55
@edolstra
Copy link
Copy Markdown
Member Author

edolstra commented Oct 1, 2020

Note that Emacs is still about 85 MiB larger than in NixOS 20.03. For a large part this is because the closure now contains two (!) copies of systemd, where previously it only depended on systemd.lib.

Edit: I created issue #99240 for that. We could just drop the systemd dependency in Emacs (looking at the source, it only affects running Emacs in daemon mode as a systemd unit, which I doubt anybody really cares about). However that wouldn't help since Emacs also depends on dbus, which in turn depends on systemd.

@ofborg ofborg bot added the 6.topic: emacs Text editor label Oct 1, 2020
@ofborg ofborg bot requested review from jwiegley and peti October 1, 2020 08:34
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 1, 2020
@adisbladis adisbladis merged commit ff9d09b into NixOS:master Oct 1, 2020
@adisbladis
Copy link
Copy Markdown
Member

it only affects running Emacs in daemon mode as a systemd unit

And to add to this, it's only relevant for socket activation, which the NixOS service doesn't use.
But as you say, emacs depends on dbus anyway so it's probably not worth the extra effort, and it would be pretty nice to switch the emacs service over to use socket activation.

@edolstra edolstra deleted the emacs-closure branch October 1, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: emacs Text editor 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emacs has gtk.dev in its closure

2 participants