Skip to content

GNOME 3.38#98316

Merged
worldofpeace merged 224 commits intostagingfrom
gnome-3.38
Oct 24, 2020
Merged

GNOME 3.38#98316
worldofpeace merged 224 commits intostagingfrom
gnome-3.38

Conversation

@doronbehar
Copy link
Copy Markdown
Contributor

@doronbehar doronbehar commented Sep 20, 2020 •
edited by worldofpeace
Loading

Progress/status

See this GitHub project for what work is in progress.

Rebase Todo's

Hydra

Jobset: https://hydra.nixos.org/jobset/nixpkgs/gnome#tabs-evaluations

This is based off https://hydra.nixos.org/build/127942802 84d74ae.

Other

Fixes #99767 + Fixes #99766 + Fixes #93993 + Fixes #94732 + Fixes #99754 .

@doronbehar

This comment has been minimized.

Sign in to view
@ofborg ofborg bot added the 8.has: documentation This PR adds or changes documentation label Sep 20, 2020
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Sep 20, 2020
@pbogdan

This comment has been minimized.

Sign in to view
@doronbehar

This comment has been minimized.

Sign in to view
@pbogdan

This comment has been minimized.

Sign in to view
@ofborg ofborg bot requested a review from vcunat September 20, 2020 14:58
jtojnar
jtojnar reviewed Sep 20, 2020
View reviewed changes
@worldofpeace worldofpeace changed the title gnome 3.38 - less dirty GNOME 3.38 Sep 20, 2020
@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Sep 20, 2020

Help will be appreciated by Meson / Gnome Gurus such as jtojnar && worldofpeace . I hope it's OK to contact you here and not in a PM or IRC, I'm just not an IRC kind of guy.

PR comments are usually better place to ask about PR anyway, people just sometimes prefer chat form (IRC or Matrix) because they find it more convenient. But that only works when people are available at the same time 🤷‍♀️

Yeah, patchShebangs is usually the proper solution, though we should check if a correct Python is selected when cross-compiling (see pkgsCross.aarch64-multiplatform.gobject-introspection).

@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Sep 20, 2020

@doronbehar I mentioned in my previous comments that PM's are okay with me, and we also have #nixos-gnome. Comments on here will be preferred though.

We also use the https://github.com/NixOS/nixpkgs/projects/30 gnome-3.38 project. Past examples like https://github.com/NixOS/nixpkgs/projects/24. This is really helpful to coordinate todo's because GitHub adores collapsing PRs like this one so at the end of it all this discussion is going to be hard to retrieve (or recall what was done)

@jtojnar

This comment has been minimized.

Sign in to view
@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Sep 20, 2020

#88222 .

@worldofpeace worldofpeace mentioned this pull request Sep 20, 2020
Closed
10 tasks
@doronbehar

This comment has been minimized.

Sign in to view
worldofpeace
worldofpeace reviewed Sep 20, 2020
View reviewed changes
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Sep 20, 2020
@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Sep 20, 2020

What I'm pushing, is what's supposed to build. I'm climbing up the dependency chain to gnome's core apps, current goal is gnome-shell.

jtojnar added 14 commits October 24, 2020 01:18
@jtojnar
pdf-quench: Switch to Python 3
f0584c5
@jtojnar
gramps: Do not use gnome3.gexiv2 alias
0e5492a
@jtojnar
vala-lint: 2019-10-11 → 2020-08-18
0992424 
Fix build.

vala-lang/vala-lint@a077bbe...fc5dd9e
@jtojnar
xmonad_log_applet: Mark as broken
6d94553 
libpanel-applet was removed in favour of libgnome-applet
@jtojnar
release-notes: Mention GNOME 3.38
346e1f0
@jtojnar
gnome3.gnome-online-miners: clean up
5e38561 
* format
* do not use aliases
* correct license
@jtojnar
gnome3.gnome-online-miners: Apply some pending patches
c9f3736 
Mainly to support Tracker 3.
@jtojnar
tracker_2: 2.3.4 → 2.3.6
a737f6e 
Disables autostart.
@jtojnar
tracker-miners-2: 2.3.3 → 2.3.5
63c7390
@jtojnar
nixos/gnome3: re-add tracker 2 dbus services
ea19238 
They are still needed by Photos, Books and Documents.
@jtojnar
gnome-photos: 3.37.2 → 3.38.0
87e3d55 
https://ftp.gnome.org/pub/GNOME/sources/gnome-photos/3.37/gnome-photos-3.37.91.news
https://ftp.gnome.org/pub/GNOME/sources/gnome-photos/3.37/gnome-photos-3.37.91.1.news
https://ftp.gnome.org/pub/GNOME/sources/gnome-photos/3.38/gnome-photos-3.38.0.news
@jtojnar
gnome3: do not use alias for gnome-photos
20e2172
@jtojnar
gnome-photos: use Tracker 3
4dd2437
@jtojnar
tracker_2: drop
61afd7f 
It does not seem to work and only semi-broken apps like Books and Documents depend on it.
@jtojnar jtojnar changed the base branch from master to staging October 23, 2020 23:24
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 23, 2020
@worldofpeace worldofpeace marked this pull request as ready for review October 23, 2020 23:39
@jtojnar
webkitgtk: clean up
8ccd765 
Remove gtk2 flag, which is no longer supported.
@worldofpeace worldofpeace merged commit 949f7f9 into staging Oct 24, 2020
@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Oct 24, 2020

Great work everyone!

@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Oct 24, 2020

Yep, this cycle had the a lot of people working to get 3.38 compared to the last few 👍

@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Oct 24, 2020

I thought the g-c-c crash was a sort of blocker..

@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Oct 24, 2020

I could not reproduce the crash after pipewire update.

@wamserma wamserma mentioned this pull request Nov 4, 2020
Closed
10 tasks
@jonafato jonafato mentioned this pull request Nov 8, 2020
Merged
10 tasks
@jtojnar jtojnar mentioned this pull request Nov 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@pSub pSub Awaiting requested review from pSub

@hedning hedning Awaiting requested review from hedning

@vcunat vcunat Awaiting requested review from vcunat

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

+1 more reviewer

@worldofpeace worldofpeace worldofpeace left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@hedning hedning

@jtojnar jtojnar

@worldofpeace worldofpeace

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python Python is a high-level, general-purpose programming language. 8.has: changelog This PR adds or changes release notes 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

8 participants

@doronbehar @pbogdan @jtojnar @worldofpeace @jonringer @srid @hedning @Atemu