Skip to content

rustup: add zlib as runtime dependency#96855

Merged
jonringer merged 1 commit intoNixOS:masterfrom
Gerschtli:fix/rustup
Sep 2, 2020
Merged

rustup: add zlib as runtime dependency#96855
jonringer merged 1 commit intoNixOS:masterfrom
Gerschtli:fix/rustup

Conversation

@Gerschtli
Copy link
Contributor

@Gerschtli Gerschtli commented Aug 31, 2020

Motivation for this change

rustup needs zlib as runtime dependency.

Fixes #92946.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

jonringer commented Aug 31, 2020

@GrahamcOfBorg eval

1 similar comment
@jonringer
Copy link
Contributor

jonringer commented Aug 31, 2020

@GrahamcOfBorg eval

@Gerschtli
Copy link
Contributor Author

Gerschtli commented Aug 31, 2020

According to the Readme OfBorg runs eval by default and I think you need to mention @ ofborg instead @ GrahamcOfBorg.

@jonringer
Copy link
Contributor

jonringer commented Aug 31, 2020

@Gerschtli it does, I just accidentally killed it for a few minutes on master, and was trying to fix PRs that were checked out during that time

@ofborg ofborg bot requested a review from Mic92 August 31, 2020 18:32
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 31, 2020
steveej
steveej approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@steveej steveej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that adding zlib to a nix-shell environment is required for rust 1.46 to work. It'd be nice to not require that workaround.

jonringer
jonringer reviewed Sep 2, 2020
View reviewed changes
jonringer
jonringer approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96855 1

1 package built:
  • rustup

@Gerschtli Gerschtli deleted the fix/rustup branch September 2, 2020 17:59
@paveloom paveloom mentioned this pull request Aug 26, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

2 more reviewers

@steveej steveej steveej approved these changes

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nightly rustc needs libz.so.1 to run

3 participants

@Gerschtli @jonringer @steveej