Skip to content

qvim: drop it#96768

Merged
danieldk merged 1 commit intoNixOS:masterfrom
peterhoeg:d/qvim
Aug 31, 2020
Merged

qvim: drop it#96768
danieldk merged 1 commit intoNixOS:masterfrom
peterhoeg:d/qvim

Conversation

@peterhoeg
Copy link
Copy Markdown
Member

@peterhoeg peterhoeg commented Aug 31, 2020

Motivation for this change

Upstream has moved development to neovim instead where this frontend is
now based on Qt5.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukateras lukateras mentioned this pull request Aug 31, 2020
Closed
@ofborg ofborg bot added 6.topic: vim Advanced text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 31, 2020
danieldk
danieldk reviewed Aug 31, 2020
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
Copy link
Copy Markdown
Contributor

@danieldk danieldk Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth adding an entry to aliases.nix.

Copy link
Copy Markdown
Member Author

@peterhoeg peterhoeg Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea - done.

@peterhoeg
qvim: drop it
8401a62 
Upstream has moved development to neovim instead where this frontend is
now based on Qt5.
@danieldk danieldk merged commit c9e9013 into NixOS:master Aug 31, 2020
@peterhoeg peterhoeg deleted the d/qvim branch September 7, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danieldk danieldk danieldk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: vim Advanced text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peterhoeg @danieldk