Skip to content

tests/postgresql-wal-receiver: Port to Python#96349

Merged
flokli merged 1 commit intoNixOS:masterfrom
helsinki-systems:feat/postgresql-wal-python
Aug 26, 2020
Merged

tests/postgresql-wal-receiver: Port to Python#96349
flokli merged 1 commit intoNixOS:masterfrom
helsinki-systems:feat/postgresql-wal-python

Conversation

@dasJ
Copy link
Copy Markdown
Member

@dasJ dasJ commented Aug 26, 2020

... and remove some weirdnesses.

  • Port to Python
  • Drop the extra pkgs, config, system args
  • Drop all with
  • Use a more standard PostgreSQL data directory
  • Use pkgs and lib from the test runner

Tested with:

  • postgresql_12
  • postgresql_11
  • postgresql_10
  • postgresql_9_6
  • postgresql_9_5

Closes #96347
cc @flokli

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ dasJ requested review from flokli and pacien August 26, 2020 08:55
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 26, 2020
@dasJ dasJ added 6.topic: testing Tooling for automated testing of packages and modules 8.has: clean-up This PR removes packages or removes other cruft labels Aug 26, 2020
pacien
pacien approved these changes Aug 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@pacien pacien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

flokli
flokli requested changes Aug 26, 2020
View reviewed changes
nixos/tests/postgresql-wal-receiver.nix Outdated
Copy link
Copy Markdown
Member

@flokli flokli Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you forget removing this?

nixos/tests/postgresql-wal-receiver.nix Outdated
Comment on lines 31 to 33
Copy link
Copy Markdown
Member

@flokli flokli Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you forget removing this?

nixos/tests/postgresql-wal-receiver.nix Outdated
Copy link
Copy Markdown
Member

@flokli flokli Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you forget removing this?

nixos/tests/postgresql-wal-receiver.nix Outdated
Copy link
Copy Markdown
Member

@flokli flokli Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be updated.

nixos/tests/postgresql-wal-receiver.nix Outdated
Copy link
Copy Markdown
Member

@flokli flokli Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be updated.

nixos/tests/postgresql-wal-receiver.nix Outdated
Copy link
Copy Markdown
Member

@flokli flokli Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be updated.

nixos/tests/postgresql-wal-receiver.nix Outdated
Copy link
Copy Markdown
Member

@flokli flokli Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be updated.

@dasJ
tests/postgresql-wal-receiver: Port to Python
ead6de5 
... and remove some weirdnesses.

- Port to Python
- Drop the extra pkgs, config, system args
- Drop all `with`
- Don't override the standard PostgreSQL directory
- Use pkgs and lib from the test runner

Tested with:
- postgresql_12
- postgresql_11
- postgresql_10
- postgresql_9_6
- postgresql_9_5

Closes NixOS#96347
cc @flokli
@dasJ dasJ force-pushed the feat/postgresql-wal-python branch from 29d5125 to ead6de5 Compare August 26, 2020 14:37
@flokli flokli merged commit 36e4ec8 into NixOS:master Aug 26, 2020
@ajs124 ajs124 deleted the feat/postgresql-wal-python branch August 27, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flokli flokli flokli approved these changes

+1 more reviewer

@pacien pacien pacien approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nixosTests.postgresql-wal-receiver needs to be ported to python

3 participants

@dasJ @flokli @pacien