Skip to content

nixosTests.hocker-fetchdocker#96076

Merged
tfc merged 2 commits intoNixOS:masterfrom
flokli:port-test-hocker-fetchdocker
Aug 24, 2020
Merged

nixosTests.hocker-fetchdocker#96076
tfc merged 2 commits intoNixOS:masterfrom
flokli:port-test-hocker-fetchdocker

Conversation

@flokli
Copy link
Copy Markdown
Member

@flokli flokli commented Aug 23, 2020

This ports over the hocker-fetchdocker VM test to the python tooling.
The test itself seems broken without internet access, so I marked it as broken for now.

I opened #96075 to unbreak the test.

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested review from danbst, dasJ, ixmatus and tfc August 23, 2020 09:23
@flokli flokli force-pushed the port-test-hocker-fetchdocker branch from 26bb050 to 6b2e748 Compare August 23, 2020 09:23
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 23, 2020
flokli added 2 commits August 23, 2020 22:42
This test tries to download from the official docker registry. I don't
know how this could ever work, but let's mark it as broken for now.
@flokli flokli force-pushed the port-test-hocker-fetchdocker branch from 6b2e748 to aa55b14 Compare August 23, 2020 20:42
@tfc tfc merged commit 45dd255 into NixOS:master Aug 24, 2020
@flokli flokli deleted the port-test-hocker-fetchdocker branch August 27, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants