mesos: remove package, module and test (and chronos/marathon which depends on it)#95507
Merged
flokli merged 8 commits intoNixOS:masterfrom Aug 16, 2020
Merged
mesos: remove package, module and test (and chronos/marathon which depends on it)#95507flokli merged 8 commits intoNixOS:masterfrom
flokli merged 8 commits intoNixOS:masterfrom
Conversation
The mesos package has been broken for >9 months, it doesn't make much sense to have the spark package depend on it (and thus being broken) by default.
The `mesos` package has been broken for >9 months.
Closed
The mesos package has been broken for >9 months.
It has been broken for >9 months.
The chronos package has been broken for > 9 months due to the breakage of the mesos package.
This failed to build for >9 months, as mesos failed to build for >9 months.
The corresponding package failed to build for >9 months.
This failed to build for >9 months.
kamilchm
approved these changes
Aug 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes mesos, its NixOS module, and the NixOS test.
It also removes chronos, marathon (and their modules), as they depend on the mesos derivation.
This has all been broken for more than 9 months, and we don't need to carry it around in such a broken state.
If someone decides to pick this up, it can be reintroduced.
Fixes #78557.
Motivation for this change
#72828
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)