mathics: remove package, module and test#95505
Merged
flokli merged 3 commits intoNixOS:masterfrom Aug 16, 2020
Merged
Conversation
The mathics package is unmaintained and doesn't build. Remove the test using it.
benley
approved these changes
Aug 16, 2020
Member
benley
left a comment
There was a problem hiding this comment.
This is OK by me, I haven't used mathics for a long time now. I'm sure it can be resurrected if anyone really misses it.
Member
|
...that said, it looks like mathics itself is not unmaintained. The current upstream repo supports up to django 1.11 and requires python >= 3.3, so we could make it work again pretty easily if anyone wants it. |
jonringer
approved these changes
Aug 16, 2020
Member
Author
|
Let's remove it for now - we can always revert if someone takes up maintainership. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mathics package has been broken for quite some time, uses python 2, and the required django version is long gone as well. Remove the package, module and the test (which still uses the perl test driver)
Fixes #80055
Motivation for this change
#72828
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)