Skip to content

marble: switch from qtwebkit to qtwebengine#94826

Merged
ttuegel merged 1 commit intoNixOS:masterfrom
bachp:marble-qtwebengine
Aug 7, 2020
Merged

marble: switch from qtwebkit to qtwebengine#94826
ttuegel merged 1 commit intoNixOS:masterfrom
bachp:marble-qtwebengine

Conversation

@bachp
Copy link
Copy Markdown
Member

@bachp bachp commented Aug 6, 2020

Motivation for this change

Switch marble from qtwebkit to the more modern qtwebengine.

#53079

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bachp bachp requested a review from ttuegel as a code owner August 6, 2020 22:32
@ofborg ofborg bot added 6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 6, 2020
@ttuegel ttuegel merged commit 328d59f into NixOS:master Aug 7, 2020
@ttuegel
Copy link
Copy Markdown
Member

ttuegel commented Aug 7, 2020

Thanks!

@veprbl veprbl mentioned this pull request Aug 20, 2020
Closed
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees

No one assigned

Labels

6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bachp @ttuegel