Skip to content

Remove docker-preloader module and test#93791

Merged
flokli merged 1 commit intoNixOS:masterfrom
nlewo:remove-docker-preloader
Aug 23, 2020
Merged

Remove docker-preloader module and test#93791
flokli merged 1 commit intoNixOS:masterfrom
nlewo:remove-docker-preloader

Conversation

@nlewo
Copy link
Copy Markdown
Member

@nlewo nlewo commented Jul 25, 2020

Motivation for this change

The NixOS test has not been ported to Python and is broken since several months. I'm no longer interested in maintaining this module and nobody seems to be interested in.
So, I propose to remove the module and its test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 25, 2020
This was referenced Aug 23, 2020
Merged
Closed
@flokli
Copy link
Copy Markdown
Member

flokli commented Aug 23, 2020

Agreed on removing this until someone steps up and keeps maintaining it.

I wasn't aware of this PR while merging in #80051, so I'll rebase this PR to apply cleanly again and then merge it in.

@flokli flokli force-pushed the remove-docker-preloader branch from 7ccbdbb to 8595a0d Compare August 23, 2020 08:49
@flokli flokli merged commit 1ddd030 into NixOS:master Aug 23, 2020
@nlewo
Copy link
Copy Markdown
Member Author

nlewo commented Aug 23, 2020

Thx, I forgot to merge it.

@chrissound
Copy link
Copy Markdown

chrissound commented Sep 30, 2025 •
edited
Loading

If it helps anyone, this functionality can be replicated now instead with oci-containers.containers it seems:

    oci-containers.containers = {
      nginx = {
        image = "docker.io/library/nginx:1.27";
      };
    };

https://stackoverflow.com/questions/79779245/how-can-i-declaratively-load-docker-images-in-nixos/79779352#79779352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nlewo @flokli @chrissound